appDisplay: Refresh folder preview when favorites change

Pinning an app from inside a folder did not refresh the
folder preview. FolderIcon._sync() was only listening
to folder GSettings changes, while pinning updates the
favorites setting instead.

As a result, _sync() was never called and the preview
could show stale icons or remain visible when the folder
became empty.

Fix this by also connecting _sync() to
AppFavorites::changed, ensuring the folder preview
updates correctly when favorites are modified.

Closes : https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/9026

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4088>

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 8430cb985404a206ded11c0477c4910c0e65de60..e52278cbabf690c9fa68ff1a793850233bdb5a6c 100644 (file)
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2299,6 +2299,9 @@ export const FolderIcon = GObject.registerClass({
 
         this._folder.connectObject(
             'changed', this._sync.bind(this), this);
+        const appFavorites = AppFavorites.getAppFavorites();
+        appFavorites.connectObject(
+            'changed', this._sync.bind(this), this);
         this._sync();
     }